Allow string labels in Bin primitive#99
Merged
matthewhorridge merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
- remove integer cast for bin labels during deserialization\n- update Bin typing to support non-integer labels\n- add serialization/transform tests for string labels\n\nImplements #96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bin.from_serialization()by removing forcedint(...)cast on labelsBininternal type hints to support non-integer labelsWhy
Issue #96 identifies that bin labels are currently forced to integers, which prevents meaningful categories like
child,teen,adult,seniorfrom being used directly in rules.Validation
venv/bin/pytest -q72 passedRelated