Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/harmonization_framework/harmonization_rule.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, List
from typing import Any, Dict, List, Optional
from .element import DataElement
from .primitives.base import PrimitiveOperation
from .primitives import PrimitiveVocabulary, Bin, Cast, ConvertDate, ConvertUnits, DoNothing, EnumToEnum, FormatNumber, NormalizeBoolean, NormalizeText, Offset, Reduce, Round, Scale, Substitute, Threshold, Truncate
Expand All @@ -8,10 +8,17 @@
# Backwards-compatible alias

class HarmonizationRule:
def __init__(self, source: DataElement, target: DataElement, transformation: List[PrimitiveOperation] = None):
def __init__(
self,
source: DataElement,
target: DataElement,
transformation: List[PrimitiveOperation] = None,
metadata: Optional[Dict[str, Any]] = None,
):
self.source = source
self.target = target
self._transform = transformation
self.metadata = metadata
self.serialization = json.dumps(self.serialize())

def serialize(self):
Expand All @@ -22,6 +29,8 @@ def serialize(self):
primitive.to_dict() for primitive in (self._transform or [])
],
}
if self.metadata:
output["metadata"] = self.metadata
return output

def __str__(self):
Expand All @@ -46,6 +55,7 @@ def from_serialization(cls, serialization):
source = serialization["source"]
target = serialization["target"]
operations = serialization["operations"]
metadata = serialization.get("metadata")
transformation = []
for operation in operations:
match operation["operation"]:
Expand Down Expand Up @@ -84,7 +94,7 @@ def from_serialization(cls, serialization):
case _:
raise ValueError(f"Unknown operation: {operation['operation']}")
transformation.append(primitive)
return HarmonizationRule(source, target, transformation)
return HarmonizationRule(source, target, transformation, metadata=metadata)


# Backwards-compatible alias
Expand Down
10 changes: 10 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from __future__ import annotations

import sys
from pathlib import Path

ROOT = Path(__file__).resolve().parents[1]
SRC = ROOT / "src"

if str(SRC) not in sys.path:
sys.path.insert(0, str(SRC))
1 change: 1 addition & 0 deletions tests/test_rule_serialization.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def test_rule_serialization_roundtrip_and_transform():
"age_text",
"age_years",
[Cast("text", "integer"), Round(0)],
metadata={"comments": ["source: demo"], "provenance": "demo"},
)

payload = rule.serialize()
Expand Down