Implement check to prevent infinite loop cases #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code introduces a check to prevent infinite loop cases. In the test case added in 'test_unsolvable', the software looped infinitely rather than raising an error. I tested this and found that the error was occurring after the cost_matrix had been padded.
An infinite loop occurs where all remaining uncovered values are DISALLOWED. This identifies the case and raises an UnsolvableMatrix exception. I have not written a test for this as my current reproducable example is a 500 by 400 matrix.
Author
|
@bmc might you have time to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code introduces a check to prevent infinite loop cases. In the test case added in 'test_unsolvable', the software looped infinitely rather than raising an error. I tested this and found that the error was occurring after the cost_matrix had been padded.
There is a further edge case where, in step 4, the only uncovered values are disallowed. The system defaults to a
minvalofsys.maxsize, which it then tries to take away from all the disallowed objects. It fails, but then loops through this process again, infinitely. I cannot find a small reproducable case for this, but have tried it with my own failing matrix (500 by 400 items)This seems to fix #28