Skip to content

Fixed FluentNumber parsing crashing on non-US locales #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mailaender wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2

Don't crash when parsing numbers

fd4980d
Select commit
Loading
Failed to load commit list.
Open

Fixed FluentNumber parsing crashing on non-US locales #12

Don't crash when parsing numbers
fd4980d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 5, 2026 in 0s

93.79% (+0.00%) compared to 6624035

View this Pull Request on Codecov

93.79% (+0.00%) compared to 6624035

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.79%. Comparing base (6624035) to head (fd4980d).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          26       26           
  Lines        1886     1887    +1     
=======================================
+ Hits         1769     1770    +1     
  Misses        117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov