CMakeLists: update min version to 3.10 for CMake >= 4.0 support#87
Open
Ansuel wants to merge 1 commit intoblunderer:masterfrom
Open
CMakeLists: update min version to 3.10 for CMake >= 4.0 support#87Ansuel wants to merge 1 commit intoblunderer:masterfrom
Ansuel wants to merge 1 commit intoblunderer:masterfrom
Conversation
Update minimum version of CMake to 3.10 for CMake >= 4.0 version support. New CMake require 3.5 as the minimum version with that increased to 3.10 in the next CMake release. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
blunderer
reviewed
Nov 24, 2025
Owner
blunderer
left a comment
blunderer
left a comment
There was a problem hiding this comment.
What bothers me with this change is that libroxml will still happily compile with older versions of CMake, and here, we will artificially break this.
Would you be able to, instead, use this recommendation (see https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#cmake-minimum-required for more details):
Update the VERSION argument value. Or, use the ... syntax
to tell CMake that the project requires at least but has been updated
to work with policies introduced by or earlier.
Setting max to 3.5, I believe, would solve both problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update minimum version of CMake to 3.10 for CMake >= 4.0 version support.
New CMake require 3.5 as the minimum version with that increased to 3.10 in the next CMake release.