Open
Conversation
src/roxml_cat.c: In function 'display_usage':
src/roxml_cat.c:21:22: error: implicit declaration of function 'basename'; did you mean 'rename'? [-Wimplicit-function-declaration]
21 | char *name = basename(prgname);
| ^~~~~~~~
| rename
src/roxml_cat.c:21:22: error: initialization of 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
src/roxml_mem.c: In function 'roxml_malloc':
src/roxml_mem.c:138:18: error: assignment to 'long unsigned int' from 'pthread_t' {aka 'struct __pthread *'} makes integer from pointer without a cast [-Wint-conversion]
138 | cell->id = pthread_self();
src/roxml_utils.h:51:16: error: returning 'pthread_t' {aka 'struct __pthread *'} from a function with return type 'long unsigned int' makes integer from pointer without a cast [-Wint-conversion]
51 | return pthread_self();
blunderer
reviewed
Nov 17, 2025
| cell = cell->next; | ||
| cell->type = type; | ||
| cell->id = pthread_self(); | ||
| cell->id = (unsigned long)pthread_self(); |
Owner
There was a problem hiding this comment.
Is fixing the other way around much harder? I'd rather make the id member of memory_cell_t a pthread_t than cast it.
Contributor
There was a problem hiding this comment.
Normally this should not pose any issue, as memory_cell_t does not appear to be an exported type (roxml_types.h is noinst).
| ROXML_STATIC_INLINE ROXML_INT unsigned long int roxml_thread_id(node_t *n) | ||
| { | ||
| return pthread_self(); | ||
| return (unsigned long)pthread_self(); |
Contributor
There was a problem hiding this comment.
I wonder what the good fix would be here ; this is an internal function that is never used through the code. Is a fix worth it? Wouldn't it be better to just remove it? Or (perhaps) use it instead of calling pthread_self() in other places of the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/roxml_cat.c: In function 'display_usage':
src/roxml_cat.c:21:22: error: implicit declaration of function 'basename'; did you mean 'rename'? [-Wimplicit-function-declaration]
21 | char *name = basename(prgname);
| ^~~~~~~~
| rename
src/roxml_cat.c:21:22: error: initialization of 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
src/roxml_mem.c: In function 'roxml_malloc':
src/roxml_mem.c:138:18: error: assignment to 'long unsigned int' from 'pthread_t' {aka 'struct __pthread *'} makes integer from pointer without a cast [-Wint-conversion]
138 | cell->id = pthread_self();
src/roxml_utils.h:51:16: error: returning 'pthread_t' {aka 'struct __pthread *'} from a function with return type 'long unsigned int' makes integer from pointer without a cast [-Wint-conversion]
51 | return pthread_self();