Skip to content

Fix --keep-ext and add --include-ext#976

Merged
genematx merged 8 commits intobluesky:mainfrom
danielballan:key-from-filename-is-none
May 1, 2026
Merged

Fix --keep-ext and add --include-ext#976
genematx merged 8 commits intobluesky:mainfrom
danielballan:key-from-filename-is-none

Conversation

@danielballan
Copy link
Copy Markdown
Member

@danielballan danielballan commented May 8, 2025

Needs unit test. Tripped over this while focusing elsewhere, bookmarking this for later.


Tested!

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

@danielballan danielballan force-pushed the key-from-filename-is-none branch from 58cee4d to b4fc8da Compare August 6, 2025 01:02
@danielballan danielballan force-pushed the key-from-filename-is-none branch from b4fc8da to 212fbba Compare December 6, 2025 19:53
@danielballan danielballan marked this pull request as ready for review December 6, 2025 19:53
@danielballan danielballan force-pushed the key-from-filename-is-none branch from 212fbba to 6a6e96d Compare April 30, 2026 19:06
Comment thread tiled/client/register.py Outdated
@danielballan
Copy link
Copy Markdown
Member Author

danielballan commented May 1, 2026

  • Address comment in line
  • Extend approach to tiled serve directory
  • Smoke test

@danielballan
Copy link
Copy Markdown
Member Author

Codecov cannot detect the coverage happening in a subprocess.

One build failed on an unrelated test. Must be a (rarely) flaky test.

FAILED tests/test_authentication.py::test_refresh_transparent[postgres_uri] - tiled.client.utils.ClientError: 401: Access token has expired. Refresh token. http://local-tiled-app/api/v1/metadata/A1

@danielballan danielballan changed the title key_from_filename default was not applied Fix --keep-ext and add --include-ext May 1, 2026
@genematx genematx merged commit 975632e into bluesky:main May 1, 2026
7 of 10 checks passed
@danielballan danielballan deleted the key-from-filename-is-none branch May 1, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants