Stream larger data#1262
Merged
danielballan merged 13 commits intobluesky:mainfrom Jan 21, 2026
Merged
Conversation
gwbischof
commented
Dec 23, 2025
7149e8b to
5bf6c20
Compare
danielballan
reviewed
Jan 2, 2026
danielballan
approved these changes
Jan 21, 2026
ZohebShaikh
pushed a commit
that referenced
this pull request
Feb 21, 2026
* fix a little bug with StreamingCache no defined * add missing dep to pixi.toml * increase the websocket max size * expost the max_size param * update docs * touch up * add more max_size params to subclasses * improve receiver handling of messages that are too big * touch ups * touch ups * move max_size param to start * disconnect when message too big * update max_size docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a max_size param for subscriptions so that clients can specify that they want to receive larger data.
This also improves the client behavior when receiving a message that is too large.
I think we ignore the codecov failures because the Starlette TestClient.websocket_connect() doesn't support
max_size.I tested this on a local tiled and it has the behavior that I was going for.
Any thoughts about what the client behavior should be when receiving data that is too large?
Test against tiled-staging worked well.
I opened an issue to fix the warnings from the docs build: #1273