Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new NoteConnect() function to establish connection with the Notecard before sending traffic, particularly for handling first boot scenarios where the Notecard may be unavailable for CRC validation. The PR also deprecates the older *WithRetry APIs in favor of using NoteConnect() followed by standard request functions.
Changes:
- Added
NoteConnect()function that retriesNoteReset()with timeout-based retry logic - Deprecated
NoteRequestResponseWithRetry()andNoteRequestWithRetry()functions with appropriate documentation updates - Moved
NoteReset()documentation from implementation to header file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| note.h | Added NoteConnect() declaration with documentation; marked NoteRequestResponseWithRetry() and NoteRequestWithRetry() as deprecated |
| n_request.c | Implemented NoteConnect() function with retry logic using timeout; removed inline documentation for NoteReset() (now in header) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3cdf068 to
c6385c2
Compare
We need a way to ensure we are talking to the Notecard, before sending traffic. This is necessary for first boot, as the Notecard is unavailable for CRC validation.
This provides an abstraction over
NoteReset, which is the preferred replacement of the deprecated*WithRetryAPIs.