Reopen map on user's last known location

[ArturoManzoli]

• Cockpit stores the user’s last viewed map location and restores it when reopening 'Flight Mode' or 'Mission Planning'.
• Option to follow the vehicle is now stored on BlueOS

Closes #2260

[ES-Alexander]

This seems to work fine in both browser and electron - nice!

That said, it seems tied to the interface, rather than actually being based on the "user"'s details. Not sure if we want this synced to the vehicle (through the user), or leave it as each frontend stores the info it needs for this...

Curious on @rafaellehmkuhl's thoughts.

---

This definitely isn't critical enough to hold up stable, but if it's approved in time it's also maybe ok to include, as something akin to a bug fix?

[rafaellehmkuhl]

This seems to work fine in both browser and electron - nice!

That said, it seems tied to the interface, rather than actually being based on the "user"'s details. Not sure if we want this synced to the vehicle (through the user), or leave it as each frontend stores the info it needs for this...

Curious on @rafaellehmkuhl's thoughts.

Also not completely sure, but I think it could make sense to tie it to the user. It's where they were.

What I'm asking myself right now is if this new behavior deals well with the current default "follow vehicle" behavior. I tried to use the PR but if the vehicle is connected it just goes there.

@ArturoManzoli @ES-Alexander any idea what should be the default behavior on each case?

[ArturoManzoli]

Also not completely sure, but I think it could make sense to tie it to the user. It's where they were.

What I'm asking myself right now is if this new behavior deals well with the current default "follow vehicle" behavior. I tried to use the PR but if the vehicle is connected it just goes there.

@ArturoManzoli @ES-Alexander any idea what should be the default behavior on each case?

I think following the vehicle would be the priority whenever the mode is turned on.
Maybe we should store the "follow vehicle" option as user preference on BlueOS. As it is now, it would reset back to it on every boot

[rafaellehmkuhl]

Also not completely sure, but I think it could make sense to tie it to the user. It's where they were.
What I'm asking myself right now is if this new behavior deals well with the current default "follow vehicle" behavior. I tried to use the PR but if the vehicle is connected it just goes there.
@ArturoManzoli @ES-Alexander any idea what should be the default behavior on each case?

I think following the vehicle would be the priority whenever the mode is turned on. Maybe we should store the "follow vehicle" option as user preference on BlueOS. As it is now, it would reset back to it on every boot

Maybe this should be a preference indeed. Go automatically to the vehicle position, home position or last map location. Sounds good. @ES-Alexander what do you think?

[ES-Alexander]

I think following the vehicle would be the priority whenever the mode is turned on.
Maybe we should store the "follow vehicle" option as user preference on BlueOS. As it is now, it would reset back to it on every boot

Agreed - if the user has asked to follow the vehicle then we should do that until they ask to stop (ideally even across sessions) 👍

That said, I think it should be tied to a profile in a user, not the user at the top level, since they may have different preferences for how they operate different vehicle types.

As an edge case, I am curious what happens when follow vehicle mode is remaining on and the vehicle has no position (e.g. for a DVL ROV that hasn't had its origin and/or starting position set yet, or a boat that is turned on inside without a GPS lock). In those cases I think the behaviour we want is to reopen where they last were, so this PR could still apply even when follow mode is on.

[rafaellehmkuhl]

@ArturoManzoli @ES-Alexander I believe we should discuss and agree on a solution to move forward with that one.

[rafaellehmkuhl]

This should not be ignored.

[ArturoManzoli]

all fixed. Ready to review

[rafaellehmkuhl]

Only minor things and we are ready to merge.

[ArturoManzoli]

Only minor things and we are ready to merge.

All issues addressed!