Skip to content

Backports/1.4/hide secondary radcam stream #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaoantoniocardoso merged 1 commit into from
Jan 28, 2026
+5 −0
Merged

Backports/1.4/hide secondary radcam stream #3747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/frontend/src/components/video-manager/VideoManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ export default Vue.extend({
if (device.name === 'Fake source') {
return has_active_stream(device) || settings.is_pirate_mode
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The condition and return value seem to contradict the comment about not showing RadCam's secondary stream.

This returns has_active_stream(device) || settings.is_pirate_mode, matching the "Fake source" behavior and still allowing the secondary stream to be shown when active or in pirate mode. If the goal is to always hide this secondary stream, this should return false (or similar) instead of delegating to has_active_stream. Otherwise, please adjust the comment to describe the intended nuanced behavior so it doesn’t mislead future readers.

}

// Do not show RadCam's secondary stream
if (device.name === 'UnderwaterCam - IPCamera (UnderwaterCam)' && device.source.endsWith('/stream_1')) {
return has_active_stream(device) || settings.is_pirate_mode
}
return true
}

Expand Down
Loading