s4cmd: avoid AttributeError on newer botocore#310
Open
robbat2 wants to merge 1 commit intobloomreach:masterfrom
Open
s4cmd: avoid AttributeError on newer botocore#310robbat2 wants to merge 1 commit intobloomreach:masterfrom
robbat2 wants to merge 1 commit intobloomreach:masterfrom
Conversation
Newer botocore has removed `vendored` entirely; try to import carefully.
Makes s4cmd work again on botocore-1.29.84.
```
Traceback (most recent call last):
File "/usr/lib/python-exec/python3.10/s4cmd", line 33, in <module>
sys.exit(load_entry_point('s4cmd==2.1.0', 'console_scripts', 's4cmd')())
File "/usr/lib/python-exec/python3.10/s4cmd", line 25, in importlib_load_entry_point
return next(matches).load()
File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/usr/lib64/python-exec/python3.10/s4cmd.py", line 255, in <module>
class BotoClient(object):
File "/usr/lib64/python-exec/python3.10/s4cmd.py", line 274, in BotoClient
botocore.vendored.requests.packages.urllib3.exceptions.ReadTimeoutError,
AttributeError: module 'botocore' has no attribute 'vendored'
```
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
4a1323f to
514e948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer botocore has removed
vendoredentirely; try to import carefully. Makes s4cmd work again on botocore-1.29.84.Signed-off-by: Robin H. Johnson robbat2@gentoo.org