Add support for Unsigned Requests#177
Open
VarunWachaspati wants to merge 2 commits intobloomreach:masterfrom
Open
Add support for Unsigned Requests#177VarunWachaspati wants to merge 2 commits intobloomreach:masterfrom
VarunWachaspati wants to merge 2 commits intobloomreach:masterfrom
Conversation
aws-cli and Boto3 both provide an option to fetch S3 objects from public buckets without explicitly signing the request using any credentials, using --no-sign-request flag. s3cmd doesn't have a similar option as such, but this could be useful to get started with s4cmd without any setup for public buckets. reference= bloomreach#139
jinnnyang
approved these changes
Jun 18, 2023
jinnnyang
approved these changes
Jun 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-cli and Boto3 both provide an option to fetch S3 objects from
public buckets without explicitly signing the request, using
--no-sign-request flag.
s3cmd doesn't have a similar option as such, but this could be
useful to get started with s4cmd without any setup for public
buckets.
Refactored code to populate boto3 client params to a separate methods,
since there are other open issues to add such similar flags such as
--no-check-certificate.
Fixes #139