Skip to content

Completed Project #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JamesSedlacek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Completed Project #222

JamesSedlacek wants to merge 1 commit into from

Conversation

@JamesSedlacek
Copy link

@JamesSedlacek JamesSedlacek commented Jun 4, 2020

swift-student
swift-student reviewed Jun 5, 2020
View reviewed changes
Copy link

@swift-student swift-student left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting the storyboards linked and tab bar working, as well as incorporating SpriteKit. I did notice a couple minor details. Your info storyboards have labels that are constrained only on two sides to a set distance. This works fine for that size phone, but doesn't allow it to respond to changing screen sizes. Also, your settings look like they are both on when the app first launches, yet they are actually turned off, so I would switch them off in the storyboard to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@swift-student swift-student swift-student left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesSedlacek @swift-student