Contained #219
Open
Contained #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeflow22
reviewed
May 19, 2020
| import UIKit | ||
|
|
||
| class GameViewController: UIViewController { | ||
|
|
There was a problem hiding this comment.
Connect SkView outlet here and do execute code.
mikeflow22
reviewed
May 19, 2020
| } | ||
|
|
||
|
|
||
| /* |
There was a problem hiding this comment.
delete boilerplate comments that have no use.
mikeflow22
reviewed
May 19, 2020
|
|
||
| class InfoDetailViewController: InfoViewController { | ||
| @IBAction func unwindSegue(_ sender: UIStoryboardSegue) { | ||
| } |
mikeflow22
reviewed
May 19, 2020
| import UIKit | ||
|
|
||
| class InfoViewController: UIViewController { | ||
|
|
There was a problem hiding this comment.
It's best practice to delete files if there is no code in it.
mikeflow22
reviewed
May 19, 2020
|
|
||
|
|
||
| @IBAction func toggleRoll(_ sender: UISwitch) { | ||
|
|
There was a problem hiding this comment.
Take the value of the switch and assign that value to an instance variable for our class object.
mikeflow22
reviewed
May 19, 2020
| } | ||
|
|
||
| @IBAction func toggleZoom(_ sender: UISwitch) { | ||
| } |
There was a problem hiding this comment.
Take the value of the switch and assign that value to an instance variable for our class object.
mikeflow22
reviewed
May 19, 2020
mikeflow22
left a comment
mikeflow22
left a comment
There was a problem hiding this comment.
Please review the following comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrflowers22