Safer literals, as const preserves route keys and reduces accidental mutation. #105
Open
Montana wants to merge 1 commit intobloomberg:mainfrom
Open
Safer literals, as const preserves route keys and reduces accidental mutation. #105Montana wants to merge 1 commit intobloomberg:mainfrom
const preserves route keys and reduces accidental mutation. #105Montana wants to merge 1 commit intobloomberg:mainfrom
Conversation
…l mutation. Signed-off-by: Michael Mendy <montana@linux.com>
Member
|
@Montana It looks like this PR does a bit more than the single line comment suggests. This change only modifies a single example project and adds new behavior. Could you please open an issue first? It would be useful to discuss what your goal is with these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safer literals, as
constpreserves route keys and reduces accidental mutation.