-
Notifications
You must be signed in to change notification settings - Fork 234
Select by column name in sqllogfill.c #5677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cf1c47a to
d6e512b
Compare
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
d6e512b to
e402935
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_timepart_multiddl_generated [core dumped]
insert_lots_ssl_generated
truncatesc_offline_generated
insert_lots
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
reco-ddlk-sql
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
insert_lots
reco-ddlk-sql
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_timepart_multiddl_generated [core dumped]
sc_timepart_logicalsc_generated [core dumped]
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
9d81eb4 to
e402935
Compare
Also, check for our own mastership while holding the bob-lock in request_logs_from_master.