Skip to content

Conversation

@markhannum
Copy link
Contributor

Also, check for our own mastership while holding the bob-lock in request_logs_from_master.

@markhannum markhannum force-pushed the sqlfill_specify_columns branch 2 times, most recently from cf1c47a to d6e512b Compare January 16, 2026 19:31
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
@markhannum markhannum force-pushed the sqlfill_specify_columns branch from d6e512b to e402935 Compare January 16, 2026 20:58
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart_multiddl_generated [core dumped]
insert_lots_ssl_generated
truncatesc_offline_generated
insert_lots

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
insert_lots
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart_multiddl_generated [core dumped]
sc_timepart_logicalsc_generated [core dumped]
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots

@markhannum markhannum force-pushed the sqlfill_specify_columns branch from 9d81eb4 to e402935 Compare January 20, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants