Remove set token optimization, fix chunk case #5672
Conversation
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
chands10
force-pushed
the
throttle_fix
branch
from
a99cbf5 to
c440575
Compare
chands10
changed the title
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_timepart [core dumped]
insert_lots_ssl_generated
insert_lots
sc_truncate
reco-ddlk-sql
upsert
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
truncatesc_offline_generated [core dumped]
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
| if (strncasecmp(p, "chunk", 5) == 0) { | ||
| p += sizeof("CHUNK"); | ||
| cdb2_skipws(p); | ||
| if (strncasecmp(p, "throttle", 8) != 0) |
There was a problem hiding this comment.
would you need this in bbgh cdb2api as well?
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
3 participants
Same as bb. Also token way had a bug with transaction chunk vs transaction chunk throttle.