cdb2api_direct test #5660
Draft
cdb2api_direct test #5660
+92
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
approved these changes
Jan 6, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_downgrade
insert_lots_ssl_generated
insert_lots
api_tst
chands10
reviewed
Jan 6, 2026
| static void load_cfg(char *db, char *tier) | ||
| { | ||
| cdb2_hndl_tp *hndl = NULL; | ||
| int rc = cdb2_open(&hndl, db, tier, 0); |
Contributor
There was a problem hiding this comment.
tier is a hostname here. Currently fails on roborivers when using 0 flag (which honestly makes sense). There's 2 reasons why is passes on bb cdb2api.
- It skips dbinfo (open does this too by default). To skip dbinfo also require to have a connection in sockpool to the db already (roborivers won't have that, at least doesn't in it's current setup?) (at least for open sockpool). If bb didn't skip dbinfo then it would also complain about using 0 as flag
2: on bb sockpool typestring is comdb2/dbname/hostname/newsql/random_roo (the m doesn't fit in). bbcdb2api doesn't care that the length of the sockpool typestr and will still attempt to contact sockpool. Open does care and will check the length (https://github.com/bloomberg/comdb2/blob/main/cdb2api/cdb2api.c#L3099). Therefore since the typestring doesn't fit, open won't skip dbinfo, and going through the normal path you can't use 0 flag and hostname
Contributor
There was a problem hiding this comment.
Also not even sure how you get a hostname/random_roo(m) combo in sockpool to start with, and not hostname/dc. Maybe because bb sockpool will open a new connection for you if needed
Signed-off-by: Mohit Khullar <mkhullar1@bloomberg.net>
mohitkhullar
force-pushed
the
cdb2api_direct_test
branch
from
b187d81 to
af87423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.