feat(da-indexer): add support for eigenda_v2 blobs retrieval via proxy#1566
feat(da-indexer): add support for eigenda_v2 blobs retrieval via proxy#1566rimrakhimov wants to merge 5 commits intomainfrom
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…d error recognition
…ocker images from PR
…successfully stored in s3
bragov4ik
left a comment
bragov4ik
left a comment
There was a problem hiding this comment.
had some pending comments I forgot about, might check again later 🙈
| always() && | ||
| (needs.test.result == 'success' || needs.test.result == 'cancelled') && | ||
| (needs.lint.result == 'success' || needs.lint.result == 'cancelled') | ||
| uses: ./.github/workflows/_docker-build-push.yml |
There was a problem hiding this comment.
is it meant to be reverted as name suggests? 👀
| let initialized_settings = initialize_s3_storage_and_return_settings(test_name).await; | ||
| S3Storage::new(initialized_settings) | ||
| .await | ||
| .expect("cannot initialize s3 storage") |
There was a problem hiding this comment.
nit: it seems that initialize_s3_storage_and_return_settings doesn't actually initialize the storage, as initialization happens right after;
maybe rename them? not sure how though :(
2 participants
The PR adds a new endpoint which allows to retrieve blobs from eigenda V2 via 3-rd party eigenda-proxy. The service, accepts the eigenda commitments and try to retrieve corresponding blob through the proxy. If successful it stores that blob in the database, so that the next time the same commitment is requested, it can be retrieved from the local database (and, thus, definitely has the corresponding blob available)