Skip to content

chore: delete redundant vercel-alias workflow#19

Merged
alextnetto merged 1 commit into
mainfrom
cleanup-dead-code
May 15, 2026
Merged

chore: delete redundant vercel-alias workflow#19
alextnetto merged 1 commit into
mainfrom
cleanup-dead-code

Conversation

@alextnetto
Copy link
Copy Markdown
Member

Summary

Delete .github/workflows/vercel-alias-pagent.yml. It's a no-op now.

Why

pagent.link is the Vercel project's auto-tracking production domain (set 2026-05-15). Pushes to main auto-alias on Vercel's side without any GitHub Action involvement. The workflow has been silently no-op'ing on the missing VERCEL_TOKEN secret since #15, so removing it costs nothing.

If we ever want a belt-and-suspenders auto-alias job, the path is: add VERCEL_TOKEN to GitHub Actions Secrets, then revert this commit. Reference implementation lives in the file we're deleting.

What else is not dead (audited)

The "what else?" question — I checked. Everything else that looked suspicious survives audit:

  • apps/web/main.ts and apps/web/vite.config.ts are entry points (referenced by index.html / Vite config convention, not via import). False positive on the "unreferenced files" grep.
  • apps/web/main.ts:36 has a TODO: make REPORT_EMAIL configurable via VITE_REPORT_EMAIL — known deferred follow-up from PR feat: HTML page format for view-only visualizations #16's review, not dead.
  • apps/mcp/server.bundle.js has third-party deprecation comments (ajv, jsdom). Bundled, not ours.
  • package-lock.json has transitive-dep deprecation warnings. Not actionable from us.
  • Railway-generated URLs (pagent.up.railway.app, pagent-observability-production.up.railway.app) are still attached to their services as fallback debugging URLs. Conservative to leave.

Test plan

  • npm run typecheck green
  • npm test — 237 pass
  • No code paths changed (workflow-only deletion)

`pagent.link` is the auto-tracking production domain on the Vercel
project (set 2026-05-15), so future pushes to `main` auto-alias
without any GitHub Action. This workflow has been silently no-op'ing
on the missing `VERCEL_TOKEN` secret since #15 anyway; removing it
cleans up a confusing CI signal and one less file to maintain.

If we ever want a belt-and-suspenders auto-alias job, the path is to
add the `VERCEL_TOKEN` secret to GitHub Actions and re-introduce the
workflow with `ALIAS: pagent.link`. Reference implementation lives in
this commit's parent.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pagent Ready Ready Preview, Comment May 15, 2026 11:49pm

Request Review

@alextnetto alextnetto merged commit fb1f8bb into main May 15, 2026
3 checks passed
@alextnetto alextnetto deleted the cleanup-dead-code branch May 15, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant