Feat/anticapture client#257
Merged
Merged
Conversation
- Pin retry to manual exponential backoff (no new dependency) - Flag setClientConfig shape as an early-validation assumption - Clarify smoke-test criterion as qualitative Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…surface Installs @anticapture/client ^1.0.0. Appends verified SDK surface section to the migration spec: function mapping, client config shape (no setClientConfig — per-call config.client closure pattern), enum value differences (OrderDirection lowercase, QueryInput_* aliases needed), type shape differences (OffchainProposal richer, Voter has extra fields), and integrated-tests decision (skip with TODO in this PR). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…icapture/client - Replace AxiosInstance constructor with AnticaptureClientConfig (baseURL, defaultHeaders, maxRetries, timeoutMs) - Build sdkConfig passed to every SDK call instead of global mutation - Implement getDAOs using getDaos() from @anticapture/client; stub all other methods - Rewrite test-helpers.ts with MSW server factory and daosResponse helper - Rewrite anticapture-client.test.ts with MSW-based getDAOs tests; skip unmigrated blocks - Skip offchain-proposal.test.ts (listOffchainProposals not migrated yet) - Add @anticapture+client to jest transformIgnorePatterns to handle ESM package Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…capture/client Implements getProposalById, getEventThreshold, listVotes, getProposalNonVoters, getOffchainProposalNonVoters, and listOffchainVotes using real SDK calls with fan-out for proposal lookups. Adds MSW tests for all 6 methods (happy + error paths). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oters; add missing edge-case tests - Fix `res?.items?.length >= 0` → `res?.items != null` so an empty array from one DAO doesn't terminate the fan-out early - Add explanatory comments on all `as any` casts for SDK dao params - Add test: returns empty array on 500 from all offchain DAOs - Add test: skips DAO on non-404 server error and continues to next DAO Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace stub with real SDK implementation using historicalVotingPower. Supports per-DAO mode and parallel fan-out across all DAOs with ASC timestamp sort. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fchain variant Replaces 'not migrated yet' stubs with real fan-out implementations that delegate to already-migrated listVotes/listOffchainVotes methods, filter offchain-only DAOs, and sort results ASC by timestamp. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
pikonha
reviewed
May 14, 2026
Member
There was a problem hiding this comment.
all of these should be removed and rely on the turbo repo
pikonha
reviewed
May 14, 2026
pikonha
approved these changes
May 15, 2026
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…-tests Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…e-client tests Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the entire monorepo from Jest to Vitest, replaces hand-rolled HTTP/GraphQL mocks in integrated tests with MSW, and refactors
packages/anticapture-clientto delegate to the upstream@anticapture/clientSDK instead of maintaining its own GraphQL codegen pipeline. The result is a smaller, type-safer client (local query files, codegen output, and generatedgql/*artifacts are removed) and a uniform testing setup across all apps and packages, withSimple<Name>in-memory doubles replacing scatteredvi.fn()/jest.mockusage.Changes
Test runner migration (Jest → Vitest)
jest.config.{js,ts}files and addedvitest.config.tsin every workspace:apps/consumers,apps/dispatcher,apps/integrated-tests,apps/logic-system,apps/subscription-server,packages/anticapture-client,packages/messages.package.jsonto use Vitest scripts and dependencies; refreshedpnpm-lock.yamlaccordingly.consumers,dispatcher,logic-system, andanticapture-clientto use Vitest APIs.Integrated tests: MSW + simpler doubles
apps/integrated-tests/src/setup/msw-server.tsand Vitest setup files (setup/vitest/global-setup.ts,setup/vitest/setup.ts); removed the oldsetup/jest/*andmocks/*(graphql-mock-setup, http-client-mock, slack/telegram mock setups, ens-resolver-mock, jest-mock-factory).Simple<Name>test clients:test-clients/simple-slack.client.ts,test-clients/simple-telegram.client.ts; removed the olderslack-test.client.ts/telegram-test.client.ts.tests/core,tests/slack, andtests/telegramto use MSW handlers and the new doubles; standardized factory and helper usage insrc/fixtures/factories/*andsrc/helpers/*.anticapture-clientrewrite over@anticapture/clientSDKcodegen.yaml, thequeries/*.graphqlfiles,src/gql/*(fragment-masking, gql, graphql, index), localschemas.ts, and the corresponding generateddist/gql/*artifacts.src/anticapture-client.tsto consume SDK types and methods; migrated each method incrementally (constructor +getDAOs, simple per-DAO methods,listProposalsper-DAO and fan-out,listVotingPowerHistory,listRecentVotesFromAllDaosplus offchain variant); fixed fan-out guard ingetOffchainProposalNonVotersand added edge-case tests.src/with-retry-and-timeout.tshelper plus tests; addedsrc/test-doubles.tsandsrc/types.ts(re-exported fromindex.ts).@anticapture/clientas a dependency and documented the SDK surface inpackages/anticapture-client/AGENTS.md.New interfaces and testability
IVotingPowerRepository,INotificationClientFactory,IEnsResolver, and anIAnticaptureClientplusnoopAnticaptureClientfor use in tests.protectedin trigger/dispatcher services so tests can exercise them without mocking.notification-factory,subscription-client,trigger-processor, and all trigger services to consume the new interfaces and SDK-sourced types.Logic system tests
tests/mocks.ts→tests/fixtures.tsand addedtests/simple-doubles.ts; updated every trigger test (new-proposal,new-offchain-proposal,proposal-finished,offchain-proposal-finished,offchain-vote-cast,voting-power,voting-reminder,threshold-repository,base-trigger) to use the new pattern.Docs and configuration
docs/and updatedAGENTS.mdfiles inconsumers,dispatcher,integrated-tests,logic-system,subscription-server, andanticapture-client..env.example,docker-compose.yml, and per-app env configs.