Refactor/snapshot voting reminder#254
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pikonha
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Snapshot (off-chain) voting reminder from the 75-80% elapsed-time window down to the 50-55% window so users are notified earlier — roughly at the midpoint of a proposal — leaving more room to act before voting closes. Also fixes a missing
daoIdargument when querying non-voters, and sets a sane default RPC for the consumer container so ENS lookups don't hang against viem's rate-limited public default.Changes
OffchainVotingReminder75→OffchainVotingReminder50(idoffchain-voting-reminder-75→offchain-voting-reminder-50) inpackages/messages/src/notification-types.ts.apps/logic-system/src/app.tsto fire at the 50% threshold (5% window unchanged).apps/dispatcher/src/app.tsto bind the newOffchainVotingReminder50notification type, and wired thedaoIdargument throughoffchainNonVotersSource.getNonVoterstoanticaptureClient.getOffchainProposalNonVoters.AnticaptureClient.getOffchainProposalNonVoters(and regenerated dist) to requiredaoIdso the underlying GraphQL request can target the correct DAO context.apps/integrated-tests/tests/telegram/offchain-voting-reminder-trigger.test.tsfor the 50-55% window (52% positive case, 40% below-threshold, 60% above-window).RPC_URL(https://ethereum-rpc.publicnode.com, overridable via env) to theconsumersservice indocker-compose.ymlto prevent the ENS resolver from hanging on viem's rate-limited default RPC.