fix: gov FE feedback (branding, pp tooltip, Telegram CTA)#1957
fix: gov FE feedback (branding, pp tooltip, Telegram CTA)#1957brunod-e wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 853afbf620
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <TelegramBotMessage /> | ||
| </div> | ||
| ) : null} | ||
| </div> |
There was a problem hiding this comment.
For on-chain proposal pages where supportValue is available, this deletion removes the only in-page Telegram bot CTA instead of restyling it: the import and component are gone, and a repo-wide search for TelegramBotMessage / ANTICAPTURE_TELEGRAM_BOT shows no replacement in the proposal overview flow. The remaining alert links live in global/mobile header or other pages, so users on the desktop proposal view no longer see the proposal-specific security-updates CTA that this change set says it preserves.
Useful? React with 👍 / 👎.
|
🚅 Deployed to the anticapture-pr-1957 environment in anticapture-infra
|
2 participants
Summary
Addresses three pieces of front-end feedback from netto.eth on the governance UI: branding casing, an unclear metric unit, and the styling of the Telegram CTA.
Context
fix/gov-fe-feedbackWhat changed
UI
ppin e.g. "+9pp" is now an inline tooltip (dotted underline) explaining percentage points: "Percentage points: the absolute change between two percentages. Going from 30% to 39% is +9pp, not +9%." The redundant title ⓘ tooltip was removed.Button(outline variant) as the action. Stacks on mobile, row with right-aligned button onsm+.Internal
KpiCardnow carries a structureddelta { value, unit, comparison }instead of a pre-joined subtext string, so the unit can be rendered as its own tooltip trigger.presentDeltareturns the unit-less value and the caller owns the unit. The "pp" tooltip copy is a static UI constant inKpiRow.Self-review
pnpm dashboard typecheck— passespnpm dashboard lint— 0 errors (pre-existing warnings only)Screenshots can be attached once the change is rendered locally.
Changeset
@anticapture/dashboard: patch — gov FE feedback fixes (branding casing, inline pp tooltip, Telegram CTA restyle)