feat: draft proposals#1910
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90434edf5b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🔍 UI Review —
|
The migration effect's deps are [daoId, dao, address], so a transient API failure during the same mount left users stranded on local/empty drafts until they remounted or switched wallet/DAO. Surface an `error` flag and `retry()` callback from useDrafts (bumped via a retryToken in the dep list), and render a Retry button in the drafts tab — both when the list is empty after failure and as an inline banner when local fallback drafts are shown. Addresses Codex review comment #3285061890 on PR #1910. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53eff25532
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…raft (#3248645685) When hydrating a draft via the shared-link API path, do not set currentDraftId unless shared.author matches the connected address. This prevents Save from calling updateDraftProposal on a draft the viewer does not own (which returns 404) and instead forks it as a new draft. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Capture address at effect start and use a cancelled flag in the cleanup so an in-flight response from a previous wallet cannot overwrite drafts after the user switches accounts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da43ac6e95
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add a cancelled flag in the shared-draft hydration effect so out-of-order responses from prior draftId values cannot overwrite the form after in-app navigation between shared links. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e889d370a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
https://app.clickup.com/t/90132341641/DEV-666