Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new validateStakeCred function that validates and extracts stake credentials from various Cardano address formats. The function supports multiple input formats including stake addresses, stake keys, stake key hashes, and script addresses, returning normalized stake credential information.
Key changes:
- Implements
validateStakeCredfunction with support for multiple bech32 address formats - Adds comprehensive test fixtures covering different stake credential types and networks
- Updates constant naming from
PrefixestoPREFIXESfor consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/validation.ts | Implements the main validateStakeCred function and helper functions, updates prefix constants |
| test/fixtures/validation.ts | Adds comprehensive test fixtures for various stake credential formats |
| test/tests/validation.test.ts | Adds test cases for the new validateStakeCred function |
| CHANGELOG.md | Documents the new feature addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
011a2ef to
6ccf414
Compare
vladimirvolek
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.