Conversation
Signed-off-by: Chen Kai <281165273grape@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the encoding of RSA public keys when creating peer IDs by adding the protobuf type field prefix that the encoder omits for the default RSA key type. This ensures compatibility with other libp2p implementations that expect this prefix when hashing protobuf-encoded keys.
Key Changes:
- Modified
fromPublicKeyto detect RSA keys and prepend the protobuf type field (0x08, 0x00) before hashing - Changed
protobuf_public_keyfromconsttovarto allow reassignment for RSA keys
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
g11tech
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR help fix zig/rust/go protobuf encoding difference, zig omits the value 0. It makes the peerid calculation inconsistent with rust/go when using RSA key.
This could be improved when we forked and changed the gremin protobuf lib.