feat: add ethlambda support #93
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c4c1275.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the ethlambda client to the lean quickstart infrastructure, enabling ethlambda nodes to be deployed alongside existing clients like zeam, ream, qlean, lantern, lighthouse, and grandine.
Changes:
- Added ethlambda client configuration and deployment support across both local and ansible deployment modes
- Updated inventory generation scripts and ansible playbooks to include ethlambda_nodes group
- Created new ethlambda ansible role with tasks and defaults
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| run-ansible.sh | Added ethlambda_nodes to the list of node groups for SSH configuration |
| local-devnet/genesis/validator-config.yaml | Added ethlambda_0 validator configuration with networking and key details |
| generate-ansible-inventory.sh | Added ethlambda_nodes group and updated comment to include ethlambda |
| client-cmds/ethlambda-cmd.sh | New client command script defining ethlambda binary and docker execution parameters |
| ansible/roles/ethlambda/tasks/main.yml | New ansible role tasks for deploying ethlambda nodes |
| ansible/roles/ethlambda/defaults/main.yml | New ansible role defaults for ethlambda deployment configuration |
| ansible/playbooks/deploy-single-node.yml | Added ethlambda deployment block and updated supported client types |
| ansible-devnet/genesis/validator-config.yaml | Added ethlambda_0 validator configuration for ansible-devnet environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: "ethlambda_0" | ||
| privkey: "299550529a79bc2dce003747c52fb0639465c893e00b0440ac66144d625e066a" | ||
| enrFields: | ||
| ip: "TBD" |
There was a problem hiding this comment.
The IP address is set to a placeholder value "TBD" instead of an actual IP address. This should be replaced with the actual IP address for the ethlambda node in the ansible-devnet environment, similar to how other nodes in the file have actual IP addresses configured.
Suggested change
| ip: "TBD" | |
| ip: "127.0.0.1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the ethlambda client: https://github.com/lambdaclass/ethlambda