Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Three changes based on bats-core best practices research: 1. Migrate $BATS_TMPDIR -> $BATS_TEST_TMPDIR in script tests. Per-test unique temp dirs prevent collision under parallel execution (bats --jobs). 2. Use $BATS_TEST_DIRNAME for path resolution in all test files. Tests now resolve fixtures and scripts relative to the test file location, not the working directory. Makes tests location-independent. 3. Switch CI from apt-get install to bats-core/bats-action@3.0.1. Handles caching and version pinning. 144 tests, all passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mpawliszyn
force-pushed
the
test-infra-improvements
branch
from
683aa58 to
c7607a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three improvements based on bats-core best practices:
$BATS_TEST_TMPDIR-- script tests use per-test temp dirs instead of shared$BATS_TMPDIR. Prevents collision under parallel execution.$BATS_TEST_DIRNAME-- all test files resolve paths relative to their location, not the working directory. Tests are now location-independent.bats-core/bats-action@3.0.1-- CI uses the official action instead of apt-get. Handles caching and version pinning.144 tests, all passing.