Repository navigation
feat: send a User-Agent on relay WebSocket upgrades - #9246
Open
wpfleger96 wants to merge 1 commit into
Open
wpfleger96 wants to merge 1 commit into
wpfleger96 wants to merge 1 commit into
Conversation
buzz-acp, buzz-cli, buzz-ws-client, buzz-pairing-cli, buzz-audio-client and the mobile app now name themselves and their version on every relay WebSocket upgrade. buzz-ws-client and buzz-audio-client default to their own name and keep a User-Agent the caller supplies. Signed-off-by: Will Pfleger <wpfleger@block.xyz> Co-authored-by: Hayt <211b96e6a2b7f45fd4047988976c7bbbeeda0c15f3ae7b32eec20834b5a55118@buzz.block.builderlab.xyz>
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relay WebSocket clients in this repo now send a
User-Agentof the form<name>/<version>on the upgrade request. The version comes from the build.buzz-acpbuzz-acp/<crate version>buzz-clibuzz-cli/<crate version>buzz-ws-client(default)buzz-ws-client/<crate version>buzz-pairing-clibuzz-pairing-cli/<crate version>buzz-audio-client(default)buzz-audio-client/<crate version>Buzz-Mobile/<app version>buzz-ws-client: every connect path sends the default. AUser-Agentin the caller'sconnect_with_headersheaders replaces it, so other consumers can identify themselves without any new API.buzz-cliuses this to send its own name.buzz-audio-client: keeps aUser-Agentalready on the host-supplied request, and adds its default otherwise.openRelayWebSocketsets the HTTP client'suserAgent, which also covers the huddle transport. Startup fills in the app version frompackage_info_plus. Until that resolves, the value isBuzz-Mobile.Each client has a test asserting the header on the upgrade request.