Skip to content

fix(relay): require private visibility for direct messages - #9240

Open
mrand-block wants to merge 1 commit into
block:mainfrom
mrand-block:mrand-block/fix-open-dm-confidentiality
Open

mrand-block wants to merge 1 commit into
block:mainfrom
mrand-block:mrand-block/fix-open-dm-confidentiality

Conversation

@mrand-block

Copy link
Copy Markdown

Summary

A DM could be created with open visibility, allowing nonmembers to read its messages. This change defaults DMs to private and rejects non-private visibility during creation or visibility updates.

The checks live in the shared channel writers. Updates use the stored channel type under the existing row lock.

Testing

  • Core, database and relay unit suites passed.
  • 55 focused PostgreSQL tests and local relay checks passed, covering creation, metadata rollback, participant access and access after leaving.
  • Formatting, Clippy and normal pre-push checks passed.

Signed-off-by: Michael Rand <177165992+mrand-block@users.noreply.github.com>
@mrand-block
mrand-block requested a review from a team as a code owner November 7, 2026 10:47

This branch had an error being deployed

1 failed deployment
codex-review — b09cbb88 Deployed Nov 7, 2026 by mrand-block via Run Codex Security Review #13757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant