Repository navigation
Give fast Builderlab models their own section and a bolt in the model picker - #2592
Conversation
salman1993
left a comment
salman1993
left a comment
There was a problem hiding this comment.
🤖 Reviewed by Salman’s AI agent on his behalf at c278fa0. LGTM.
Traced the catalog field through Builderlab’s choice mapping into creation/settings and the shared family menu. Missing/non-true flags remain false; Fast appears on menu rows, effort submenu triggers and the selected accessible label, using the existing suffix recipe and compact-trigger behavior. Reviewed the added tests and current passing hosted checks. No app visual/interaction check or live staging inference performed.
c278fa0 to
27f3f8b
Compare
Co-authored-by: mbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <baxen@squareup.com>
Menu rows lay out children with a row gap, so the suffix floated as its own column. Wrap name and suffix in one text run. Co-authored-by: mbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <baxen@squareup.com>
27f3f8b to
2fa2ad9
Compare
baxen
changed the title
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Fast models now lead the family menu in a Fast section, each with its family logo, and stay in their families too. A bolt after the name replaces the ' · Fast' text in menu rows and on the trigger; its text stays for screen readers and the trigger's accessible name. Co-authored-by: mbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <baxen@squareup.com>
2fa2ad9 to
a068ecf
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fa2ad975e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: mbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <baxen@squareup.com>
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord’s automated source review on Wes’s behalf, integrating Rocket (catalog/lifecycle), Mantis (selection/security), and Groot (product/accessibility).
Reviewed head b95c4ba02222f34fc35fe04cd2f02718c840b2d5 against target base 81aaf1343b0f1ce7c62a5aea58cd5193cf3422c4 (merge-base 418dcf3f0a9ccbf5e62f7fbf477bf81e914dbd8c).
[P2] Remove internal details from the public PR description. The first What bullet links to a private upstream repository, and the final Testing bullet identifies an employee-only community and its production/staging catalog contents. These disclose internal coordination/deployment details on this public PR, contrary to the repository’s open-source boundary. Remove that private URL and the deployment-specific catalog details. Keep the generic optional fast contract, compatibility behavior, and accurately scoped validation results. The identifiers are deliberately not repeated here.
No functional code defect found in the nine-file diff: strict boolean parsing, both Builderlab callers, Fast/family selection, existing effort controls, accessible labels, and bundled help were inspected. Source-only review: no tests, builds, app interactions, live catalogs, or performance measurements were run; runtime and rendered accessibility remain unverified. No images were attached to the inspected description.
|
🤖 ART for @baxen: thanks. I removed the private upstream link, the internal catalog service name and the deployment-specific catalog details from the description. The earlier text is still in GitHub's edit history for this description, so a maintainer may want to delete that revision. |
|
🤖 Design review of Intent: help people find faster Builderlab models in Create agent and model settings. Required follow-up — show selection with a fill. Select a Fast model, reopen the menu and move to another row: the selected model has only a checkmark, without a persistent selected fill. The new rows use the default check treatment in ModelFamilyMenu.tsx. Use The shortcuts preserve the same model IDs and existing Thinking reset in both Builderlab screens. Fast remains available in accessible labels and bundled help. Source review only. No screenshots attached to the inspected description. No app run, tests, live keyboard/screen-reader check, or rendered verification of themes, window/text sizes, long names, many models, and loading/error/empty states. |
Why
Builderlab remote agents can now run on models served on faster hardware, which respond much sooner than the others. The model picker should show which choices are fast, so people can compare them side by side.
What
fastflag on each model in the Builderlab model catalog. If the flag is missing or nottrue, the model is treated as not fast. Older servers keep working.ModelChoicegets an optionalfastfield.glass-ghosttrigger. It replaces the earlier " · Fast" text. The word "Fast" stays in the accessible name.Design: the section uses the shared
MenuGroup+MenuGroupLabel emphasis="quiet"andMenuSeparator; rows reuse the family menu'sbuzz-select-leadinglogo slot. The bolt is the existingLightningIconintext-subtle, following design review feedback. That icon also marks workflows elsewhere in Buzz; inside the model picker the two don't meet. No new component or token.Testing
vitest run src/features/agents src/bundled/builderlab: 109 files and 2,086 tests pass. New tests cover parsing the catalog flag, the choice mapping, the Fast section (its order, and leaving it out when no model or every model is fast) and the bolt in family rows and on the trigger.pnpm typecheckandpnpm design:checkare clean.ModelFamilyMenuwith a fake catalog on a throwaway design-server page (Chromium, dark and light). Not checked in a live app session, at narrow widths or with enlarged text.