Repository navigation
feat(berd-call): attribute call usage to its client - #476
Draft
johnmatthewtennant wants to merge 1 commit into
Draft
johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
Signed-off-by: John Tennant <jtennant@block.xyz> Co-authored-by: Catherine <67d27b10dcca1d5140f1b9e34c5f44ae44ac70530820011b1d2071de5a6a26d3@buzz.block.builderlab.xyz>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate standalone call usage by its caller.
berd-call start --client terminal|buzz-pluginstamps the same boundedclientvalue on the call's start and end events; omitted attribution defaults toterminal. The flag is start-only and is not saved as a speech preference. The Buzz plugin companion detects CLI support before passingbuzz-plugin, preserving older CLI compatibility.The client emits
berd-call-otlp-logs-v3. The companion gateway schema must merge and deploy before a release sends these events. No new events or other telemetry fields are added.Related issue
Extends standalone call telemetry. The separate per-voice counts use v2; this contract leaves that schema independent.
Testing
The payload regression fails before the change and passes after it. Tests cover both start/end client values, default terminal attribution, invalid/duplicate CLI values and exclusion from child speech settings.
The built companion gateway forwards start/end records for both clients unchanged through both ingestion aliases, rejects unknown client text and the old schema, preserves token validation and collector errors, and drains on shutdown. Real lifecycle validation is incomplete: both retained and fresh test Macs block in CoreAudio default-input configuration with loopback speech services. No successful native start/end attribution is claimed. The current staging gateway rejects v3 with HTTP 400; its new schema has not been deployed, so live ingestion is not verified. These remain release gates.