Implement bounded LRU map for peer known inv hashes #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v doesn't grow indefinitely
Member
Author
|
@sondreb please review this when you have a moment |
Member
Author
|
@DavidGershony please review when you have a moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LruHashSet and use it in some behaviors, it will make sure the inv doesn't grow indefinitely
This solves CVE https://invdos.net/paper/CVE-2018-17145.pdf
And is based on bitcoin core bitcoin/bitcoin#2192
and ported from stratis node stratisproject/StratisFullNode@454e4d7
Thanks @zeptin