Fix redis-cli command not found error#2
Merged
bloboss merged 2 commits intoNov 15, 2025
Conversation
The workflow was failing because redis-cli is not installed on GitHub Actions runners (Ubuntu host). The manual health check was redundant since service containers already have built-in health checks configured. Problem: - Line 88 in .github/workflows/test.yml tried to run redis-cli on host - redis-cli only exists inside the Redis container, not on the runner - This caused "command not found" errors in CI/CD pipeline Solution: - Removed manual redis-cli ping check from setup step - GitHub Actions automatically waits for service health checks - Redis service has --health-cmd "redis-cli ping" configured - No behavioral change - Redis is still verified before tests Other redis-cli usage verified as correct: - docker-compose.test.yml: Health check runs inside container ✅ - Makefile: Uses docker-compose exec to run inside container ✅ Fixes CI/CD pipeline failures related to missing redis-cli command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.