levenshtein: wrap to sha256 for state hashing#24
Closed
tmc wants to merge 3 commits intoblevesearch:masterfrom
Closed
levenshtein: wrap to sha256 for state hashing#24tmc wants to merge 3 commits intoblevesearch:masterfrom
tmc wants to merge 3 commits intoblevesearch:masterfrom
Conversation
Given modern go module management, this is not necessary
Replace cryptographically broken MD5 with more secure SHA256 hash function for state identification in parametric DFA implementation. Required for FIPS 140 compliance in environments where MD5 is not permitted.
Replace blevesearch/mmap-go with upstream edsrzf/mmap-go.
Member
|
superseded by #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modernizes the dependency management, and replaces the md5 hash in levenshtein which is not allowed in the go fips140 configuration.
This also switches to the upstream mmap-go implementation which has a few fixes not yet in the blevesearch mmap-go fork.
This change has negligible performance impact:
Fixes #23