Skip to content

Fixed character removal when artist joinphrase is set to the end #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Masterisk-F wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed character removal when artist joinphrase is set to the end #649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31ae17d
Fixed character removal when artist joinphrase is set to the end
Masterisk-F May 7, 2025
675fd2a
fix remaining issue with artist name
Masterisk-F Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rubyripper/metadata/musicbrainz/musicbrainzReleaseParser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def analyzeResult
variousArtists = true
end
end
@md.artist = @md.artist[0..-4]
@md.artist = @md.artist[0..-4] if @md.artist.end_with?(' / ')
if @musicbrainzRelease.elements['title'] and @musicbrainzRelease.elements['title'].text
@md.album = @musicbrainzRelease.elements['title'].text
end
Expand Down Expand Up @@ -164,7 +164,7 @@ def analyzeResult
# ' / ' is default separator
artist << (credit.attributes['joinphrase'] || ' / ')
end
artist = artist[0..-4]
artist = artist[0..-4] if artist.end_with?(' / ')
varArtist[track.elements['position'].text.to_i] = artist
end
# extraDiscInfo => [Depends. What do you want?]
Expand Down