Skip Sentry in test environments#167
Open
mendral-app[bot] wants to merge 1 commit into
Open
Conversation
Add early return in init_sentry() when pytest is detected in sys.modules or BL_TYPE=test environment variable is set. This prevents the sys.settrace hook from capturing test-originated exceptions and sending them to Sentry production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytestinsys.modulesorBL_TYPE=testenvironment variablesys.settracehook from capturing test-originated exceptions (likeValueErrorfrom incomplete mocks) and sending them to Sentry productionContext
The SDK's custom Sentry integration uses
sys.settrace()to capture exceptions fromsite-packages/blaxel. During CI test runs, this captures errors from test code (e.g., MagicMock objects passing throughHTTPStatus()) and reports them to Sentry production. This caused 104 new error groups in the sdk-python@0.2.55 release.Related insight: Incomplete mock leaks ValueError to Sentry
Changes
import osto imports insentry.pyinit_sentry()when:pytestis present insys.modules(always true during test execution)BL_TYPEenvironment variable is set totest(set inconftest.py)Note
Created by Mendral. Tag @mendral-app with feedback or questions.