Replace fallback with MissingCredentials#162
Open
mendral-app[bot] wants to merge 1 commit into
Open
Conversation
When credentials exist but don't match any known auth type (e.g. only refresh_token/access_token), the auth() function previously returned a raw BlaxelAuth base class whose .token property raises NotImplementedError. Replace with MissingCredentials that raises an actionable CredentialsError guiding users to run `bl login` or set BL_API_KEY.
Contributor
|
@Mendral are you sure? the default one could also be for unauthenticated resources? We don't have only authenticated thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlaxelAuthbase class fallback inauth()with aMissingCredentialssentinel that raises an actionableCredentialsErrorwhen credentials exist but no supported auth method matches (e.g. onlyrefresh_token/access_tokenpresent)NotImplementedError: Subclasses must implement the token propertyin productionContext
Resolves insight: Unhandled auth fallback returns abstract base class
Sentry shows this error occurring with sdk-python@0.2.55 when users have a
~/.blaxel/config.yamlworkspace entry withrefresh_token/access_tokenbut nodevice_code,api_key, orclient_credentials.Changes
src/blaxel/core/authentication/__init__.py: Replace line 129'sBlaxelAuth(...)withMissingCredentials(...)providing a clear messagetests/core/test_authentication_env_vars.py: Add test covering the incomplete credentials fallback pathNote
Created by Mendral. Tag @mendral-app with feedback or questions.