Add KeyError to ignored exceptions#161
Open
mendral-app[bot] wants to merge 1 commit into
Open
Conversation
KeyError and AttributeError are normal control-flow exceptions in Python (EAFP pattern, dict-like __getitem__, hasattr/getattr). They should not be reported to Sentry by the sys.settrace handler. This eliminates false-positive KeyError reports from dict-like model classes (e.g. DriveMountInfo.__getitem__) during test runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyErrorandAttributeErrorto_IGNORED_EXCEPTIONSin the Sentry trace handler to eliminate false-positive reports from dict-like__getitem__methods andhasattr/getattrpatterns (EAFP style)Related insight: https://app.mendral.com/insights/01KTSHD0ZDFZ2AAENVZ8TA55MT
Note
Created by Mendral. Tag @mendral-app with feedback or questions.