Skip to content

[WIP] Convert Task and Lazys so they can be (de)serialized#86

Open
blairconrad wants to merge 9 commits intomasterfrom
convert-awkward-types
Open

[WIP] Convert Task and Lazys so they can be (de)serialized#86
blairconrad wants to merge 9 commits intomasterfrom
convert-awkward-types

Conversation

@blairconrad
Copy link
Copy Markdown
Owner

Fixes #81.

This solution is independent of serializers, and supports Tasks, Tasks<T>s, and Lazy<T>s, including any (directly) nested combinations of these, e.g. Lazy<Task<T>>.
However, these are only supported as the "top": as a direct return value, or out or ref parameter. A List<Task<T>> would not be handled.

@blairconrad
Copy link
Copy Markdown
Owner Author

@CableZa, I think this pull request will satisfy your requirement for recording and playing back a Task-returning method. In particular, I added a test case for a Task<int>, which seemed quite similar to the test you added to #79. Are you interested in taking a look? Trying it out? I could release an -alpha, if it makes it easier.

@blairconrad blairconrad force-pushed the convert-awkward-types branch from eb4746d to 8c331c1 Compare June 23, 2020 01:44
@CableZa
Copy link
Copy Markdown

CableZa commented Jun 23, 2020

Awesome @blairconrad, I will check this out!

@blairconrad blairconrad force-pushed the convert-awkward-types branch from 8c331c1 to 5a8d70a Compare June 23, 2020 12:05
@blairconrad blairconrad force-pushed the convert-awkward-types branch from 5a8d70a to 6fb3f25 Compare June 25, 2020 14:29
@blairconrad
Copy link
Copy Markdown
Owner Author

Hey, @CableZa. Any feedback? Did it work out for you? Not work out for you?

@CableZa
Copy link
Copy Markdown

CableZa commented Feb 11, 2022

Hey @blairconrad, sorry for taking close on a year for responding. Though this does look like it would cover what I was keen for at the time, I ended up taking a different strategy regarding testing and test doubles.

Thanks so much for taking the time, I have learned a lot from looking through the code in SelfInitializingFakes, as well the response to my initial PR.
I have a much better understanding of developing cross framework/core libraries, as well as the expectations and process of contributing to OSS projects.

Till the next time, cheers!

@blairconrad
Copy link
Copy Markdown
Owner Author

Thanks so much for taking the time, I have learned a lot from looking through the code in SelfInitializingFakes, as well the response to my initial PR. I have a much better understanding of developing cross framework/core libraries, as well as the expectations and process of contributing to OSS projects.

Hey, @CableZa. Good to hear from you. While I'm sorry that you were never able to take advantages of the changes in this pull request, I'm very glad that you found value in the exchange. Happy OSSing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Task return value serialization

2 participants