Skip to content

fixes to loading config file and a few other little things#1

Open
cboursnell wants to merge 22 commits into
blahah:masterfrom
cboursnell:master
Open

fixes to loading config file and a few other little things#1
cboursnell wants to merge 22 commits into
blahah:masterfrom
cboursnell:master

Conversation

@cboursnell

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't have a default config - there's no reason the user would have this file and we want to throw an error if they don't provide a config file

Comment thread lib/assemblotron.rb Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 0) spaces for indentation.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing after comma.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing after comma.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missing after comma.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

Comment thread lib/assemblotron.rb Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surrounding space missing for operator '+'.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add basename? The whole point of using which is to get the full path to the executable, because backticks are unstable in whether they use the same shell as the one you're in (and therefore might have a different PATH).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants