fix: safe access for potentially missing canvas index and caches#161
Merged
GamerGirlandCo merged 5 commits intoblacksmithgu:masterfrom Mar 15, 2026
Merged
Conversation
|
Since Version 1.12.2 of Obsidian this bug rendered Datacore completely broken. Workaround was disabling "canvas" from INDEXABLE_EXTENSIONS |
Collaborator
|
what if we were to simply delay canvas indexing until the caches have been loaded? maybe we could see if the linkupdater class emits any useful events? |
This was referenced Mar 3, 2026
Contributor
Author
GamerGirlandCo
approved these changes
Mar 15, 2026
Collaborator
GamerGirlandCo
left a comment
GamerGirlandCo
left a comment
There was a problem hiding this comment.
just tested, and it looks like it works. will merge and release ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a TypeError: Cannot read properties of undefined (reading 'canvas') that occurs during background file reloading and improves type safety by removing any casts.
The Problem
The plugin assumed this.fileManager.linkUpdaters.canvas always existed. In some environments, this path is undefined, causing a crash during file import.
The code relied on as any casting to access internal Obsidian APIs, hiding potential type issues.
The Fix
Runtime Safety: Added optional chaining (?.) and fallback objects in src/index/web-worker/importer.ts and src/index/import/canvas.ts.
Type Safety: Extended src/typings/obsidian-ex.d.ts to correctly type the internal linkUpdaters structure, removing the need for as any casting.
This ensures the plugin handles missing internal API data gracefully and adheres to better TypeScript practices.
Use this updated description when you update the PR on GitHub! Make sure you pushed the commits first.
Once you're done with the fix branch, we can switch back to feature/quick-launch to finish verifying that feature.