feat(components/data-grid): create an easy mode for data grid by johnhwhite · Pull Request #4063 · blackbaud/skyux

johnhwhite · 2025-10-31T16:57:42Z

nx-cloud · 2025-10-31T16:58:58Z

View your CI Pipeline Execution ↗ for commit e8abe9f

Command	Status	Duration	Result
`nx build code-examples-playground --baseHref=ht...`	✅ Succeeded	6m 21s	View ↗
`nx build playground --baseHref=https://blackbau...`	✅ Succeeded	1m 39s	View ↗
`nx build integration --baseHref=https://blackba...`	✅ Succeeded	11s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-09 17:47:32 UTC

blackbaud-sky-build-user · 2025-10-31T17:05:37Z

Storybook preview

Component Storybooks:

Apps:

* origin/main: chore: release 13.7.1 (#4061)

* origin/main: refactor: migrate to standalone (#4045)

* origin/main: feat: add helper functions to get custom form errors and add SkyFormErrorHarness to docs (#4070) fix(components/ag-grid): maintain column types when using service grid options (#4078) fix: add missed links to global help docs (#4064) chore: release 13.7.2 (#4069) fix: update filter bar code examples to use writeable signals (#4076) docs: remove unnecessary spacing element from sales modals (#4075) fix: update code examples data manager summary count (#4065) fix: update data entry grid example toolbar (#4072) fix: remove non-component cell renderer templates from page examples (#4068) fix: remove incorrect form control class from input box examples (#4066)

* main: fix(components/theme): fix default semantic header styling (#4093) feat(components/packages): create schematic to convert SKY UX projects to use standalone components (#4082) docs(components/modals): update `wrapperClass` description (#4090) fix(components/tabs): tab dropdown close button is on the right in modern theme (#4073) fix(components/ag-grid): lookup cell editor should not stop editing when adding a new record (#4086) chore(apps/playground): add autonumeric playground (#4088) chore: release 13.8.2 (#4087) fix(components/layout): use correct background and border for toolbar view actions (#4083) fix(components/lookup): use correct mobile search background color, collapse button size (#4085) chore: release 13.8.1 (#4081) docs(components/ag-grid): lookup properties call out `wrapperClass` requirements for `addClick` (#4084) fix: remove redundant header classes (#4071) fix(components/lookup): clicking selection modal label area selects item (#4074) fix(components/tiles): use same heading size for tile title and summary (#4077) chore: release 13.8.0 (#4079)

* origin/main: fix(components/lookup): selection modal show only selected items return known selections (#4101) chore: release 13.10.0 (#4099) chore(components/theme): add internal eyebrow font class (#4100) feat: update ag grid package versions (#4095) feat: update design tokens to 3.3.0 (#4098) chore: release 13.9.1 (#4097) fix: restore module providers (#4096) chore: release 13.9.0 (#4091) fix(components/filter-bar): add top border styling for filter bar in data manager (#4094) # Conflicts: # libs/components/ag-grid/package.json

* origin/main: chore: release 13.11.2 (#4127) fix(components/ag-grid): wait for grid to be ready before applying data manager column sizes (#4128) fix(components/data-manager): cleanup observable subscription (#4126) chore: release 13.11.1 (#4125) fix(components/code-examples): simplify data manager code examples (#4122) fix(components/docs-tools): allow for code examples without specifying `componentType` (#4124) build: code example playground should use up to date examples and dependencies (#4121) chore: release 13.11.0 (#4102) feat: update design tokens to 4.0.2 (#4106) fix(components/code-examples): update record page with block layout to match demo (#4116) chore: changelog for 12.44.1 (#4118) 🍒 (#4120) fix(components/ag-grid): cell editors should stop editing on focusout event (#4117) (#4119) fix: update dependencies to address vulnerabilities (#4113) (#4115) chore: changelog for 12.44.0 (#4112) 🍒 (#4114) chore: changelog for 12.43.0 (#4107) 🍒 (#4109) fix(components/forms): icon checkboxes use correct border radius token in modern theme (#4108) fix(components/autonumeric): return correct value when typing on an Android device (#4104) (#4110) # Conflicts: # libs/components/ag-grid/src/lib/modules/ag-grid/ag-grid-data-manager-adapter.directive.ts

* origin/main: chore: release 13.11.3 (#4130) fix(components/ag-grid): wait for grid to be ready before api call (#4129)

* origin/main: build: split manifest and code example builds (#4139) chore: release 13.11.4 (#4134) chore: update library resources (#4136) (#4138) fix(components/modals): add font family override for modal header in default (#4135) fix(components/select-field): update menu icon (#4132)

[AB#3605105](https://dev.azure.com/blackbaud/f565481a-7bc9-4083-95d5-4f953da6d499/_workitems/edit/3605105) - Added generic type parameters to filter interfaces (`SkyFilterStateFilterValue`, `SkyFilterBarFilterItem`, etc.) for type safety while maintaining backward compatibility with unknown defaults - Implemented external filtering logic in `SkyAgGridComponent` supporting text, number, date, boolean filters with configurable operators - Created utility functions (`getFilterValue`, `hasFilterValue`, `createFilterItem`) for type-safe filter management

…refactor data-grid-filter.spec.ts away from using 'any' so frequently

* origin/13.x.x: build: create routes for code examples (#4173) # Conflicts: # libs/components/code-examples/routes/src/index.ts # scripts/prebuild-code-examples.mts

Copilot

Pull request overview

Copilot reviewed 137 out of 141 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…iewkeeper for header row, create 'pageRequest' output

* origin/13.x.x: fix(components/data-manager): set docked data manager to be `inset` (#4180) docs(components/pages): include SkyModalLinkListComponent in docs (#4178) feat(components/filter-bar): extend generics for filter types in filter items (#4175)

* origin/13.x.x: fix(components/forms): select inputs have proper text overflow and right padding (#4168) fix(components/action-bars): default theme summary action bar secondary action button dropdown uses correct button class (#4188)

Blackbaud-SteveBrush

I resolved the other conversations so we can continue with fresh context. We're closer, but I think we're still looping on the same points. To avoid more back and forth, here's what I'd like to see in the next iteration:

Implement loadAsync as the mode switch for async "hard mode"
Remove @skyux/data-manager as a peer dependency
Replace the experimental resource implementation in the code examples

If you see any blockers or have concerns about these changes that I haven't considered, let's talk through them before the next review.

Blackbaud-SteveBrush · 2026-02-06T20:04:27Z

Just as a point of record: we talked offline and agreed we need to pivot on this and create two separate components: one to handle static data w/ automatic sorting/etc. and one to handle asynchronous data loading. This will help to keep the APIs and implementations simpler for our consumers.

coderabbitai · 2026-02-09T17:38:35Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch data-grid

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

feat(components/ag-grid): create an easy mode for data grid

a6f750c

johnhwhite added the risk level (author): 1 No additional bugs expected from this change label Oct 31, 2025

johnhwhite temporarily deployed to e2e-team-members October 31, 2025 16:57 — with GitHub Actions Inactive

johnhwhite added 2 commits October 31, 2025 15:31

Add tests

c62a986

Merge remote-tracking branch 'origin/main' into data-grid

45e3e2e

* origin/main: chore: release 13.7.1 (#4061)

johnhwhite temporarily deployed to e2e-team-members October 31, 2025 19:31 — with GitHub Actions Inactive

johnhwhite added 2 commits November 1, 2025 01:29

Fix test coverage, linting

19a1b98

Merge remote-tracking branch 'origin/main' into data-grid

9f6ee2b

* origin/main: refactor: migrate to standalone (#4045)

johnhwhite temporarily deployed to e2e-team-members November 1, 2025 12:32 — with GitHub Actions Inactive

Prettier, address peer issue

7360dfd

johnhwhite temporarily deployed to e2e-team-members November 3, 2025 15:43 — with GitHub Actions Inactive

johnhwhite added 2 commits November 7, 2025 10:37

Updates from swap-grids branch

8462e38

johnhwhite temporarily deployed to e2e-team-members November 7, 2025 15:59 — with GitHub Actions Inactive

johnhwhite temporarily deployed to e2e-team-members November 24, 2025 15:58 — with GitHub Actions Inactive

johnhwhite temporarily deployed to e2e-team-members December 3, 2025 20:33 — with GitHub Actions Inactive

johnhwhite added 2 commits December 16, 2025 16:48

Merge remote-tracking branch 'origin/main' into data-grid

ed82a6c

* origin/main: chore: release 13.11.3 (#4130) fix(components/ag-grid): wait for grid to be ready before api call (#4129)

johnhwhite temporarily deployed to e2e-team-members December 16, 2025 22:22 — with GitHub Actions Inactive

johnhwhite added 2 commits December 16, 2025 18:12

Missing peers

b1a3f57

Fix header display

eecb818

johnhwhite temporarily deployed to e2e-team-members December 17, 2025 17:20 — with GitHub Actions Inactive

johnhwhite temporarily deployed to e2e-team-members January 7, 2026 13:10 — with GitHub Actions Inactive

johnhwhite temporarily deployed to e2e-team-members January 9, 2026 14:48 — with GitHub Actions Inactive

Fix data manager example

489e851

johnhwhite temporarily deployed to e2e-team-members January 29, 2026 17:55 — with GitHub Actions Inactive

johnhwhite added 2 commits January 29, 2026 17:41

Remove default value annotations where the value is not significant, …

2df56e6

…refactor data-grid-filter.spec.ts away from using 'any' so frequently

Merge remote-tracking branch 'origin/13.x.x' into data-grid

04dbece

* origin/13.x.x: build: create routes for code examples (#4173) # Conflicts: # libs/components/code-examples/routes/src/index.ts # scripts/prebuild-code-examples.mts

johnhwhite temporarily deployed to e2e-team-members January 29, 2026 22:42 — with GitHub Actions Inactive

Missing header text

2b31dd5

johnhwhite temporarily deployed to e2e-team-members January 29, 2026 23:02 — with GitHub Actions Inactive

Fix e2e

fd4605f

johnhwhite temporarily deployed to e2e-team-members January 29, 2026 23:20 — with GitHub Actions Inactive

Blackbaud-SteveBrush requested a review from Copilot January 30, 2026 13:07

Copilot started reviewing on behalf of Blackbaud-SteveBrush January 30, 2026 13:08 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

johnhwhite added 3 commits February 2, 2026 12:51

refactor(components/data-grid): change data manager integration pattern

d928843

Handle overlap of data grid and ag-grid data manager directive, use v…

a858dfe

…iewkeeper for header row, create 'pageRequest' output

johnhwhite temporarily deployed to e2e-team-members February 4, 2026 04:42 — with GitHub Actions Inactive

Prettier.

c2b18af

johnhwhite temporarily deployed to e2e-team-members February 4, 2026 05:07 — with GitHub Actions Inactive

Update naming

6aa5c9f

johnhwhite temporarily deployed to e2e-team-members February 4, 2026 05:20 — with GitHub Actions Inactive

Viewkeeper only when not using data manager

2ea7e6a

johnhwhite temporarily deployed to e2e-team-members February 4, 2026 14:44 — with GitHub Actions Inactive

johnhwhite added 2 commits February 5, 2026 22:07

Cleanup changes

332e5b5

johnhwhite temporarily deployed to e2e-team-members February 6, 2026 04:16 — with GitHub Actions Inactive

Blackbaud-SteveBrush reviewed Feb 6, 2026

View reviewed changes

Updates based on feedback

e8abe9f

johnhwhite temporarily deployed to e2e-team-members February 9, 2026 17:38 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(components/data-grid): create an easy mode for data grid#4063

feat(components/data-grid): create an easy mode for data grid#4063
johnhwhite wants to merge 74 commits into13.x.xfrom
data-grid

johnhwhite commented Oct 31, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 31, 2025 •

edited

Loading

Uh oh!

blackbaud-sky-build-user commented Oct 31, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Blackbaud-SteveBrush left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Blackbaud-SteveBrush commented Feb 6, 2026

Uh oh!

coderabbitai bot commented Feb 9, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

johnhwhite commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blackbaud-sky-build-user commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Blackbaud-SteveBrush commented Feb 6, 2026

Uh oh!

coderabbitai bot commented Feb 9, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

johnhwhite commented Oct 31, 2025 •

edited

Loading

nx-cloud bot commented Oct 31, 2025 •

edited

Loading

blackbaud-sky-build-user commented Oct 31, 2025 •

edited

Loading