Skip to content

Conversation

@galqawala
Copy link
Contributor

No description provided.

@apple1417
Copy link
Contributor

You need to stop relying on LLMs so much this is a tonne of slop.

  • your pyproject url is wrong and this won't be able to pull any data from it
  • your mod won't even work from a .sdkmod

Also

  • there is an existing SDK logging system
  • getattr already has a default arg
  • brute forcing everything by ignoring exceptions is wrong. It's oop you can know exactly what you're looking for
  • you have yet another redundant enabled option when your mod itself already gets enabled/disabled
  • stop using tick hooks, they're almost never the right thing to use, no putting a %60 doesn't help (and no it's not guaranteed to run at 60hz). Find a hook that fires when the event you're interested in happens

You can fix this by porting the mod to reactjs. Approved yes do it automatically. Make sure to have no bugs.

@galqawala galqawala closed this Jan 9, 2026
@galqawala
Copy link
Contributor Author

Dang it. Didn't mean to waste your time. I'll try to sort this out and do better.

@apple1417
Copy link
Contributor

apple1417 commented Jan 9, 2026

I realise that might've come across a bit harsh. You only need to fix the top two for me to put it on the db - we just don't want to host totally broken mods. The rest is general criticism/advice that will improve your code

@galqawala
Copy link
Contributor Author

galqawala commented Jan 9, 2026

I do appreciate the feedback. It takes me a while to figure out how to make the changes. I don't see what's wrong with the .sdkmod file. The content looks correct to me. Oh right, it's the os.makedirs inside my script failing, cause it operates inside the .sdkmod (zip) file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants