Skip to content

observable: allow dumping multiple values without a formatter #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bonzini wants to merge 1 commit into
base: master
Choose a base branch
from
Open

observable: allow dumping multiple values without a formatter #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rx.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,13 @@ end
-- @arg {function=tostring} formatter - A function that formats one or more values to be printed.
function Observable:dump(name, formatter)
name = name and (name .. ' ') or ''
formatter = formatter or tostring

local onNext = function(...) print(name .. 'onNext: ' .. formatter(...)) end
local onNext
if formatter then
onNext = function(...) print(name .. 'onNext: ' .. formatter(...)) end
else
onNext = function(...) print(name .. 'onNext: ', ...) end
end
local onError = function(e) print(name .. 'onError: ' .. e) end
local onCompleted = function() print(name .. 'onCompleted') end

Expand Down
8 changes: 6 additions & 2 deletions src/observable.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,13 @@ end
-- @arg {function=tostring} formatter - A function that formats one or more values to be printed.
function Observable:dump(name, formatter)
name = name and (name .. ' ') or ''
formatter = formatter or tostring

local onNext = function(...) print(name .. 'onNext: ' .. formatter(...)) end
local onNext
if formatter then
onNext = function(...) print(name .. 'onNext: ' .. formatter(...)) end
else
onNext = function(...) print(name .. 'onNext: ', ...) end
end
local onError = function(e) print(name .. 'onError: ' .. e) end
local onCompleted = function() print(name .. 'onCompleted') end

Expand Down