fix: simplify release#21
Merged
bitwise-fast-forward-merge[bot] merged 3 commits intoJun 29, 2026
Merged
Conversation
Add a build-job step that runs git diff --exit-code -- dist after make build, gated on a committed dist/ existing (hashFiles dist/**), so a repo that ships a checked-in dist/ (e.g. a JavaScript Action) fails the PR when the committed artifact drifts from source. This catches staleness pre-merge instead of after a release is already cut, and is a no-op for repos that do not commit a dist/. Drop the npm ci steps from the make and e2e jobs: the Makefile targets install their own dependencies, so the workflow only sets up the Node toolchain rather than pre-installing. Keeps the Makefile the single build boundary. Signed-off-by: Deavon M. McCaffery <dmccaffery@users.noreply.github.com>
The publish job rebuilt via make build and ran git diff -- dist only after release-please had already created the release and tag, so a stale dist/ could not gate the release -- it just left the vanity tags unmoved. That verification now lives in ci.yaml (pre-merge), so drop the build and verify from release entirely. With nothing left to build or verify, the publish job collapsed to a pure vanity-tag move. Replace it and the goreleaser job's duplicate tag step with a single vanity-tags job that needs both release-please and goreleaser: one implementation for both paths, and -- because it needs goreleaser -- the tags advance only after GoReleaser has published on the Go path, never pointing the floating major tag at a half-finished release. The not-cancelled guard keeps the job eligible when goreleaser is skipped (non-Go path); the result check runs the move only when goreleaser succeeded or was skipped, never on failure. Also drop the now-unused node-version-file input: it only ever fed the publish job's setup-node, which is gone. No consumer passes it to the release workflow, so this is not a breaking change in practice. Signed-off-by: Deavon M. McCaffery <dmccaffery@users.noreply.github.com>
Reflect the relocation of the committed-dist/ check into ci.yaml, the removal of release-time build and verify, the single consolidated vanity-tags job, and that CI no longer runs npm ci (the Makefile installs its own deps). Drop the stale node-version-file entry from the release inputs in the catalog. Signed-off-by: Deavon M. McCaffery <dmccaffery@users.noreply.github.com>
Contributor
|
Note Merging this PR: this repository merges by fast-forward so every The branch must be up to date with |
Collaborator
Author
|
/auto-merge |
bitwise-fast-forward-merge
Bot
added
the
auto-merge
Contributor
|
Note Auto-merge armed. Once this PR is approved and every required check Remove the |
Contributor
|
Cannot
|
tiffanywang3
approved these changes
Jun 29, 2026
Contributor
|
Cannot
|
Contributor
|
Cannot
|
Contributor
|
Fast-forwarded |
bitwise-fast-forward-merge
Bot
merged commit 5c254dd
into
bitwise-media-group:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.