Conversation
No new features except using return in overrides only when a method has a return value. added documentation and stubbed out some tests for cases I thought of so far
methods in doubles now get a return value based on the return type defined in the metadata, this avoids returning null when we should not and datatype mismatch issues with return types
* Use a global InnerClassRegestry to get inner class paths * code review
* Implmeneted whitelist for class names Added a list of all classes that exist in ClassDB that are 'valid' at addons/gut/class_list.cfg. This was generated from the file names that exist in Godot's repo at doc/classes. * made test more OS independant
As much as the convoluted generation of the list of NativeClass names/NativeClass references was fun to make, it was an over-engineered Rube Golbergery pain. This PR alters the stub lookup dictionary to use the names for Native Classes instead of the reference to them, thus allowing me to remove the enjoyable but invariably flawed dynamically generated list. Hopefully these are not "famous last words".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.