Skip to content

[PM-32067] - Add Provider Ability View#7200

Open
jrmccannon wants to merge 1 commit intomainfrom
jmccannon/ac/pm-32067-add-provider-ability
Open

[PM-32067] - Add Provider Ability View#7200
jrmccannon wants to merge 1 commit intomainfrom
jmccannon/ac/pm-32067-add-provider-ability

Conversation

@jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Mar 11, 2026

🎟️ Tracking

PM-32067

📔 Objective

This adds Provider Ability View, repository methods, stored procedure and tests for the new cache to use.

@jrmccannon jrmccannon requested review from a team as code owners March 11, 2026 19:21
@jrmccannon jrmccannon requested a review from JimmyVo16 March 11, 2026 19:21
@jrmccannon jrmccannon added the ai-review Request a Claude code review label Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.48%. Comparing base (3b9db31) to head (31b812c).

Files with missing lines Patch % Lines
...rk/AdminConsole/Repositories/ProviderRepository.cs 0.00% 13 Missing ⚠️
...er/AdminConsole/Repositories/ProviderRepository.cs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
+ Coverage   57.43%   61.48%   +4.05%     
==========================================
  Files        2032     2032              
  Lines       89377    89398      +21     
  Branches     7944     7945       +1     
==========================================
+ Hits        51332    54968    +3636     
+ Misses      36202    32505    -3697     
- Partials     1843     1925      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details9a56d311-f127-42e0-8d3f-c285202f34f4

Great job! No new security vulnerabilities introduced in this pull request

@@ -0,0 +1,8 @@
CREATE VIEW [dbo].[ProviderAbilityView]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is this view necessary? We already have a view called ProviderView that contains all of the columns in the Provider table. Can you just select the columns you need from ProviderView in your stored procedure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done according to our contributing docs.

@jrmccannon jrmccannon requested a review from mkincaid-bw March 17, 2026 23:56
SET NOCOUNT ON

SELECT
[Id],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but you might want to change it to SELECT * to match the contributing docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants