Conversation
|
Claude finished @jrmccannon's task in 5m 16s —— View job I'll analyze this and get back to you. |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
+ Coverage 57.39% 61.50% +4.10%
==========================================
Files 2031 2032 +1
Lines 89273 89394 +121
Branches 7935 7944 +9
==========================================
+ Hits 51235 54978 +3743
+ Misses 36195 32491 -3704
- Partials 1843 1925 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Infrastructure.EntityFramework/AdminConsole/Repositories/OrganizationRepository.cs
Outdated
Show resolved
Hide resolved
JimmyVo16
left a comment
JimmyVo16
left a comment
There was a problem hiding this comment.
Some small questions, but overall it looks good.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs
Outdated
Show resolved
Hide resolved
|
| @@ -0,0 +1,28 @@ | |||
| CREATE VIEW [dbo].[OrganizationAbilityView] | |||
There was a problem hiding this comment.
❓ Is this view necessary? We already have a view called OrganizationView that contains all of the columns in the Organization table. Can you just select the columns you need from OrganizationView in your stored procedure?
There was a problem hiding this comment.
This was done according to our contributing docs.
4 participants
🎟️ Tracking
PM-32066
📔 Objective
This adds a dedicated SQL View for the Organization Ability. This includes a new repository method and integration tests validating it correctly maps those fields. It will be used in future stories.